----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16331/#review30617 -----------------------------------------------------------
Ship it! This looks great Ross! Thanks for the comments around pagination configuration too. - Benjamin Hindman On Dec. 17, 2013, 10:45 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16331/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2013, 10:45 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Paginated all tasks on the web UI home page. > > Angular UI already included a Pagination directive that renders a > Bootstrap-styled pagination list. This configures that directive and > adds paginated task tables to the homepage. > > * Pagination displays only if there are more items than can fit on a > single page > * Default itemsPerPage is 50, which will mean 50 Active Tasks and 50 > Completed Tasks on the home page. > Review: http://reviews.apache.org/r/16331 > > > Diffs > ----- > > src/webui/master/static/css/mesos.css > fa5f36b4f89c5c2011426cdcfd7ac75f32711541 > src/webui/master/static/home.html ff9d132404f1f96bf9f468329a6c615262c51c3d > src/webui/master/static/js/app.js 61fccfb5c4cf65f11ef6976b860ee8f32d6da148 > src/webui/master/static/js/controllers.js > 20c2da9852458b7f907cfef5d90237d5d3654d87 > > Diff: https://reviews.apache.org/r/16331/diff/ > > > Testing > ------- > > * Ran Marathon and long-lived-framework to generate ~1400 completed tasks > * Rendered the home page in Safari, Chrome, and Firefox > > Render time is ~550ms in Chrome per paginated page. A good portion of that is > parsing HTML for tooltips, which can be removed in a future commit. > > > Thanks, > > Ross Allen > >
