----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16742/#review31443 -----------------------------------------------------------
Ship it! Looking forward to see the tests get sped up! src/master/master.hpp <https://reviews.apache.org/r/16742/#comment59935> A comment about making these public for testing would be great. src/tests/mesos.cpp <https://reviews.apache.org/r/16742/#comment59938> Let's add a TODO here (and below) to instead return a Future instead of doing an await and let the tests wait via ASSERT_READY instead of ASSERT_SOME. Sound good? src/tests/mesos.cpp <https://reviews.apache.org/r/16742/#comment59936> s/Master/master/ src/tests/mesos.cpp <https://reviews.apache.org/r/16742/#comment59937> s/Master/master/ - Benjamin Hindman On Jan. 9, 2014, 1:03 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16742/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2014, 1:03 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-881 > https://issues.apache.org/jira/browse/MESOS-881 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 95b9cecd6f9ea0afb3f7f9753a3a06c0c8d8f9d4 > src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364 > > Diff: https://reviews.apache.org/r/16742/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
