> On Jan. 11, 2014, 12:46 a.m., Ross Allen wrote: > > src/webui/master/static/js/app.js, line 307 > > <https://reviews.apache.org/r/16787/diff/2/?file=420293#file420293line307> > > > > Can this move to the directive's template? DOM manipulation should be > > left up to Angular. > > Thomas Rampelberg wrote: > There isn't a template for the directive. I couldn't figure out a way to > instantiate directives programatically.
Would a template like this work?: <div data-ng-transclude></div> <div m-pagination></div> - Ross ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16787/#review31553 ----------------------------------------------------------- On Jan. 11, 2014, 12:18 a.m., Thomas Rampelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16787/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2014, 12:18 a.m.) > > > Review request for mesos and Ross Allen. > > > Bugs: mesos-900 > https://issues.apache.org/jira/browse/mesos-900 > > > Repository: mesos-git > > > Description > ------- > > Implemented a table directive that allows for sorting and pagination. > > Review: http://reviews.apache.org/r/16787 > > > Diffs > ----- > > src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621 > src/webui/master/static/directives/pagination.html PRE-CREATION > src/webui/master/static/framework.html > 72e14dfb58895e43a10f10c139a983a78b3e8878 > src/webui/master/static/frameworks.html > 39e7883ffe001ff33ed1b35108c893fa8ff1f92d > src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f > src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab > src/webui/master/static/js/controllers.js > 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7 > src/webui/master/static/offers.html > 215d65e1ad30fb0df06bcf05cec797d60672ec66 > src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf > src/webui/master/static/slave_executor.html > 519847c0de077717c88c4d35804ad40d339d4246 > src/webui/master/static/slave_framework.html > 947bab12eec8c3be5c3893b873b4b6378c8dcbbb > src/webui/master/static/slaves.html > ef5b66290e65408312dcf1e59221ee9517b37203 > > Diff: https://reviews.apache.org/r/16787/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Rampelberg > >
