-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13604/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 7:08 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-375
https://issues.apache.org/jira/browse/MESOS-375
Repository: mesos-git
Description
-------
Dumping data into Statistics leads to high memory consumption for various
reasons. We had to encode the string values of the statistical information into
a unique string key ("frameworkId/ExecutorId/statistic_name"), all of these
combinations consume a lot of memory. This also made it clunky in terms of
retrieving the latest information. This now uses TimeSeries<ResourceStatistics>
to efficiently store the monitoring information.
My subsequent change in this chain of reviews returns immediate values to
simplify the statistics.json endpoint.
This also uses JSON::Protobuf I recently added to simplify the JSON generation
substantially!
Diffs (updated)
-----
src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578
src/slave/monitor.cpp a931c4f35a8793c66ee03de82f0e0a21b92f8ffa
src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253
Diff: https://reviews.apache.org/r/13604/diff/
Testing
-------
make check (no test modifications needed for this change as it preserves the
API)
Thanks,
Ben Mahler
