----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16851/#review31757 -----------------------------------------------------------
src/webui/master/static/directives/tableHeader.html <https://reviews.apache.org/r/16851/#comment60477> Change to type="search" from HTML5 types. src/webui/master/static/directives/tableHeader.html <https://reviews.apache.org/r/16851/#comment60478> Bootstrap has a few classes to make inputs look nicer. This could use "form-control input-sm" to get standard styles and slightly smaller padding. Also, no need to have the self-closing tag in HTML5 for <input> elements because they have no children. The "/" can be dropped. - Ross Allen On Jan. 14, 2014, 2:49 a.m., Thomas Rampelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16851/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2014, 2:49 a.m.) > > > Review request for mesos and Ross Allen. > > > Repository: mesos-git > > > Description > ------- > > Added filtering to all tables. > > > Diffs > ----- > > src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef > src/webui/master/static/css/mesos.css > e034ea04101348b8900aea3866b4250186e85e99 > src/webui/master/static/directives/pagination.html > dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd > src/webui/master/static/directives/tableHeader.html PRE-CREATION > src/webui/master/static/framework.html > 08b8afac28f252f348a2ca3ed0fcc55353373c71 > src/webui/master/static/frameworks.html > 29683dfd6480f8c1667adabae2e9c166e841eafc > src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26 > src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e > src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457 > src/webui/master/static/offers.html > 1cce0309e1268dab1e96e2cdfee81620d512b69b > src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea > src/webui/master/static/slave_executor.html > 81c10cbf4dd77f65dd8c3081281740c2be1e5b56 > src/webui/master/static/slave_framework.html > 04a041e9a4e8e1364617d09412f0a81a160ee48a > src/webui/master/static/slaves.html > ec31d4b6f3235a3cc98079875295b407de06eec8 > > Diff: https://reviews.apache.org/r/16851/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Rampelberg > >