----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16839/#review31774 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/16839/#comment60496> Also, consider moving all http related functions to src/http.cpp - Jie Yu On Jan. 14, 2014, 7:02 p.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16839/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2014, 7:02 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Jeff Currier, and Jie > Yu. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-902 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-902 > > > Repository: mesos-git > > > Description > ------- > > Add post function to http.hpp of libprocess. > > This adds the post equivalent of the get function to http.hpp. > > The existing get method is refactored into internal::httpRequest > with arguments for method, query, and body. > > The get and post functions can then be implemented as simple > wrapper of internal::httpRequest. > > There are also new unit tests to verify the existing behavior of > get and the new post behavior. > > See: https://issues.apache.org/jira/browse/MESOS-902 > > Review: https://reviews.apache.org/r/16839 > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 5bdd520c9e0bcc0a2d3a4554cc4ced99dcf78b51 > 3rdparty/libprocess/src/process.cpp > 2d193b13cde92a061b02f903a5d6471ff90cb12a > 3rdparty/libprocess/src/tests/http_tests.cpp > 68d1a1b2ed5645d861b1e613aed9731368ebdc6a > > Diff: https://reviews.apache.org/r/16839/diff/ > > > Testing > ------- > > added new unit tests > make check > > > Thanks, > > Charlie Carson > >
