Oops. Sorry, I missed that. Will fix it. - Jie
On Thu, Jan 16, 2014 at 8:04 AM, Benjamin Hindman <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16433/ > > Ship it! > > src/log/tool/initialize.cpp<https://reviews.apache.org/r/16433/diff/2/?file=424584#file424584line137> > (Diff > revision 2) > > 137 > > return Error("Not expecting discarded future"); > > Different message? > > > > src/log/tool/read.cpp<https://reviews.apache.org/r/16433/diff/2/?file=424586#file424586line172> > (Diff > revision 2) > > 172 > > return Error("Not expecting discarded future"); > > Different message? > > > - Benjamin Hindman > > On January 16th, 2014, 6:42 a.m. UTC, Jie Yu wrote: > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan > Xu. > By Jie Yu. > > *Updated Jan. 16, 2014, 6:42 a.m.* > *Bugs: * MESOS-736 <https://issues.apache.org/jira/browse/MESOS-736> > *Repository: * mesos-git > Description > > See summary. I also pulled storage related code out (I haven't changed them) > from replica.cpp. > > > Testing > > make check > > Diffs > > - src/Makefile.am (cf0c8c6) > - src/log/leveldb.hpp (PRE-CREATION) > - src/log/leveldb.cpp (PRE-CREATION) > - src/log/main.cpp (f07bd10) > - src/log/replica.hpp (d1f5ead) > - src/log/replica.cpp (82c2157) > - src/log/storage.hpp (PRE-CREATION) > - src/log/tool.hpp (PRE-CREATION) > - src/log/tool/initialize.hpp (PRE-CREATION) > - src/log/tool/initialize.cpp (PRE-CREATION) > - src/log/tool/read.hpp (PRE-CREATION) > - src/log/tool/read.cpp (PRE-CREATION) > > View Diff <https://reviews.apache.org/r/16433/diff/> >
