----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17076/#review32226 -----------------------------------------------------------
3rdparty/libprocess/include/process/http.hpp <https://reviews.apache.org/r/17076/#comment60955> this is probably a API consistency question and I'm the new guy - but to me, a post w/o either a body or a contentType is incorrect. The entire purpose of a POST is to upload a body and you need to know the content type to know what to do with the body when it arrives. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/17076/#comment60957> what is the rationale for reversing the order of body and contenttype? I would think we'd want them in order they appear on the wire in the request so that they are more intuitive. - Charlie Carson On Jan. 17, 2014, 11:41 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17076/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2014, 11:41 p.m.) > > > Review request for mesos, Benjamin Hindman and Charlie Carson. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp a8b1636 > 3rdparty/libprocess/src/process.cpp 936f118 > > Diff: https://reviews.apache.org/r/17076/diff/ > > > Testing > ------- > > will include test fixes in the following patches. > > > Thanks, > > Jie Yu > >
