----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17078/#review32249 -----------------------------------------------------------
Ship it! Ditto about the use of Some. (But I'm sitting beside benh and I see he is making some improvements related to this). - Ben Mahler On Jan. 17, 2014, 11:45 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17078/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2014, 11:45 p.m.) > > > Review request for mesos, Benjamin Hindman and Charlie Carson. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/files_tests.cpp a696aa2 > src/tests/gc_tests.cpp 6638a4a > src/tests/logging_tests.cpp 58e9b33 > src/tests/monitor_tests.cpp a341893 > > Diff: https://reviews.apache.org/r/17078/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >