----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13603/#review32507 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/13603/#comment61368> Maybe add a comment about where these come from and/or a TODO to eventually move them? Also, do you think they're better here than statistics.cpp? 3rdparty/libprocess/src/tests/statistics_tests.cpp <https://reviews.apache.org/r/13603/#comment61376> What about just overloading the == operator instead? 3rdparty/libprocess/src/tests/timeseries_tests.cpp <https://reviews.apache.org/r/13603/#comment61377> Okay, so maybe a templated overload? ;) - Benjamin Hindman On Jan. 17, 2014, 3:58 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13603/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2014, 3:58 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > The first part of this change is the removal of the archive operation. > > This also exposes a TimeSeries data structure used by Statistics. > > The goal here is to provide reasonable historical information for high > frequency time series that rapidly exceed capacity. > TimeSeries allows a window of values to be stored, while "sparsifying" older > values when the capacity is exceeded. > See the documentation on TimeSeries for details. > > An alternative, more deterministic approach, is to use sampling on older > values. > Both approaches have their advantages and disadvantages. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 47e6d02c29fc4485e5d32bc6adaea62c82c1d60e > 3rdparty/libprocess/include/process/statistics.hpp > ce122a5eaa1aa9c09207cc8c9428136b681561cf > 3rdparty/libprocess/include/process/timeseries.hpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 67f7f9b3b05c8bc9b0f6281689223996ddfa68d1 > 3rdparty/libprocess/src/statistics.cpp > d4ba9f146f7b9b46525a0e27fbfb3d61a21a94fc > 3rdparty/libprocess/src/tests/statistics_tests.cpp > e6c9a1b776d6f3339f96898c3501d2a00c416006 > 3rdparty/libprocess/src/tests/timeseries_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/13603/diff/ > > > Testing > ------- > > Added tests to verify the truncation and sparsification of time series. > > > Thanks, > > Ben Mahler > >
