----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17013/#review32657 -----------------------------------------------------------
Is this patch final/reviewable? Or do you plan to follow up with a new diff and get this the tests reenabled? In that case it might make sense to rename isolator_tests too. src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/17013/#comment61560> XXX as a work in progress RR? Or else, should this be a TODO? src/tests/cluster.hpp <https://reviews.apache.org/r/17013/#comment61561> Wrap and indent. There seem to be a space before slave.containerizer too. src/tests/containerizer.hpp <https://reviews.apache.org/r/17013/#comment61562> Wrap please. src/tests/containerizer.cpp <https://reviews.apache.org/r/17013/#comment61563> Wrap please. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/17013/#comment61564> src/tests/mesos.cpp <https://reviews.apache.org/r/17013/#comment61565> Wrap please. - Niklas Nielsen On Jan. 21, 2014, 12:05 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17013/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 12:05 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Jason > Dusek, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Updated tests to use Containerizer. > > A few isolator specific tests haven't been updated. > > The tests require a different cgroup mount configuration; please see > https://issues.apache.org/jira/browse/MESOS-926 for preliminary documentation. > > > Diffs > ----- > > src/tests/allocator_tests.cpp c9592d4baf9f8a29624722930eefe82ea9c1e129 > src/tests/cgroups_isolator_tests.cpp > 1f5ce764a895fefb24126e39a283a8efc290d580 > src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b > src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108 > src/tests/containerizer.hpp PRE-CREATION > src/tests/containerizer.cpp PRE-CREATION > src/tests/fault_tolerance_tests.cpp > 60e06cc52d102ade687b095db474c0278ad508cc > src/tests/gc_tests.cpp 6638a4ac37cf80c86cf0a7ccd609868d2581716c > src/tests/isolator.hpp 6431dd2b6f441764c1e193aa2f19a6d38848e458 > src/tests/isolator_tests.cpp 45a41ca177efbc200c5e83448f92b4f1d8ca30e1 > src/tests/master_contender_detector_tests.cpp > 9cd576f21561a86588ee0ea8a8458a9371284d47 > src/tests/master_tests.cpp d34450bf84704b224f4e2dbc61ce100b33d14027 > src/tests/mesos.hpp d7bdaee3cfd2bad95a12daf8737896becd1dcf18 > src/tests/mesos.cpp 1b1b4cc1fd6bd2823a82e08c8e37005ab65f5874 > src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253 > src/tests/paths_tests.cpp 40c644cf945c08e08ec9bc44e7d828c2547ba4cf > src/tests/slave_recovery_tests.cpp 5a4c4fc4f687a37409d1afbda4c0d07fcdc3a4c7 > src/tests/test_framework_test.sh 277245d563dc129ebeaabff1fae8707110e7879a > > Diff: https://reviews.apache.org/r/17013/diff/ > > > Testing > ------- > > make check # OSX and Linux > > > Thanks, > > Ian Downes > >
