----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17286/#review32686 -----------------------------------------------------------
Ship it! src/log/catchup.hpp <https://reviews.apache.org/r/17286/#comment61628> If the caller can use an arbitrary proposal number than this should be an Option rather that assume semantics of passing '0'. Can we clean this up and update the comment please? src/log/catchup.hpp <https://reviews.apache.org/r/17286/#comment61629> What are the circumstances where someone would want to pass None? Should just just be a Duration with a default? src/log/catchup.cpp <https://reviews.apache.org/r/17286/#comment61630> s/. Retry it/, retrying - Benjamin Hindman On Jan. 24, 2014, 1:01 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17286/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 1:01 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > In case of a network blip (zookeeper network), log::catchup could get stuck > even if all replicas reemerge later. This is not ideal for some users such as > log::recover. > > So I introduced an optional timeout for log::catchup so that the catchup > operation on each position will be retried if timeout happens. > > > Diffs > ----- > > src/log/catchup.hpp 3652830 > src/log/catchup.cpp 5825eae > src/tests/log_tests.cpp e493af4 > > Diff: https://reviews.apache.org/r/17286/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
