----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17346/#review32858 -----------------------------------------------------------
src/java/jni/org_apache_mesos_Log.cpp <https://reviews.apache.org/r/17346/#comment61859> Shouldn't be: position.get().get()? src/java/jni/org_apache_mesos_Log.cpp <https://reviews.apache.org/r/17346/#comment61860> Ditto here. src/log/log.hpp <https://reviews.apache.org/r/17346/#comment61862> Adjust the comments here. "A none result means the writer has lost exclusive write access." src/log/log.hpp <https://reviews.apache.org/r/17346/#comment61863> Ditto here. src/log/log.cpp <https://reviews.apache.org/r/17346/#comment61864> Using a Future here seems to be not necessary. What about the following: static Option<Log::Position> position(const Option<uint64_t>& position); - Jie Yu On Jan. 25, 2014, 12:44 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17346/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2014, 12:44 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/java/jni/org_apache_mesos_Log.cpp > 36c636d155c1581eeb7734cdbc5b6fac4ca42440 > src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5 > src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2 > src/tests/log_tests.cpp e493af4f2f2435efe168d07acd267b61afd37fe4 > > Diff: https://reviews.apache.org/r/17346/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
