> On Jan. 27, 2014, 11:54 p.m., Ian Downes wrote: > > According to Linus the file descriptor has been closed even if EINTR is > > returned and it should not be closed again. Later in the thread he > > explicitly says that the glibc macro is incorrect. > > > > http://linux.derkeiler.com/Mailing-Lists/Kernel/2005-09/3000.html > > > > Posix documentation says the state of the file descriptor is unspecified on > > EINTR.
[Incorrect in the sense that it shouldn't be used to wrap a close()] - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17427/#review32914 ----------------------------------------------------------- On Jan. 27, 2014, 10:16 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17427/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 10:16 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See above, note that GNU offers TEMP_FAILURE_RETRY as a macro for this. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > bba6f43eaeba0238a5db6e388902d92eb18f14f5 > > Diff: https://reviews.apache.org/r/17427/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
