----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32919 -----------------------------------------------------------
src/webui/master/static/config.html <https://reviews.apache.org/r/17431/#comment61949> Add a `class="modal-title"` here to remove the bottom/top margin from the heading. That comes from core Bootstrap: http://getbootstrap.com/javascript/#modals src/webui/master/static/config.html <https://reviews.apache.org/r/17431/#comment61950> Can this describe the format? Maybe "Master URL" src/webui/master/static/config.html <https://reviews.apache.org/r/17431/#comment61951> Needs an ID matching the `for` attribute of the associated <label>: id="masterHost" - Ross Allen On Jan. 27, 2014, 11:56 p.m., Thomas Rampelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17431/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 11:56 p.m.) > > > Review request for mesos and Ross Allen. > > > Bugs: mesos-885 > https://issues.apache.org/jira/browse/mesos-885 > > > Repository: mesos-git > > > Description > ------- > > Enabled configuration of the mesos master from the UI. > > Review: http://reviews.apache.org/r/17431 > > > Diffs > ----- > > src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 > src/webui/master/static/config.html PRE-CREATION > src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 > src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 > src/webui/master/static/js/controllers.js > afb24fb9c2184772f7314162f5637dbabaa2ab94 > > Diff: https://reviews.apache.org/r/17431/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Rampelberg > >
