----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17480/#review33107 -----------------------------------------------------------
Ship it! Not too bad! 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/17480/#comment62382> Hook a brother up with some parens! 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/17480/#comment62383> Are you worried that adding clock::advanced will overflow either? Also, any reason not to add clock::advanced to duration.get() instead of to Time(...)? - Benjamin Hindman On Jan. 29, 2014, 3:38 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17480/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 3:38 a.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-952 > https://issues.apache.org/jira/browse/MESOS-952 > > > Repository: mesos-git > > > Description > ------- > > We now track the total Duration that the Clock has been advanced. > This is then used to ensure that Clock::now() returns a consistent value > after Clock::resume() is called. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/time.hpp > 307fd2ca9341ec4eb26107bcb07d4e17bdc0e0a6 > 3rdparty/libprocess/src/process.cpp > bc7a1c5890df7c763b0b140b47966e457e519208 > > Diff: https://reviews.apache.org/r/17480/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
