----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17476/#review33089 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/sequencer.hpp <https://reviews.apache.org/r/17476/#comment62511> I'd like to s/Sequencer/Sequence/. 3rdparty/libprocess/include/process/sequencer.hpp <https://reviews.apache.org/r/17476/#comment62354> s/non pending/non-pending/ 3rdparty/libprocess/include/process/sequencer.hpp <https://reviews.apache.org/r/17476/#comment62512> Can we comment what this onAny implies please? 3rdparty/libprocess/include/process/sequencer.hpp <https://reviews.apache.org/r/17476/#comment62513> Can we comment what this onAny implies please? 3rdparty/libprocess/src/tests/sequencer_tests.cpp <https://reviews.apache.org/r/17476/#comment62510> It's great to show the randomized test, but can we have a basic test which just shows the example use case first? A lot of people will use that to see what this thing is supposed to do! - Benjamin Hindman On Jan. 29, 2014, 1:40 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17476/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 1:40 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > One think I haven't done yet is to make it accepts '_Defer' types. (Just > curious why Future.onAny can accept defer without doing something special). > > Also, we can get rid of the SequencerProcess if we use a mutex to protect > 'last'. Not sure which one is better. > > The discard semantics here is a bit tricky. Basically, I wanna support > discarding a single callback without affecting other callbacks. Also, when > the Sequencer object is deleted, I wanna discard all the pending callbacks. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 40f01a7b3803696ccca440c8326e1d6d7c377459 > 3rdparty/libprocess/include/process/sequencer.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/sequencer_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17476/diff/ > > > Testing > ------- > > make check > > repeated 1000 times > > > Thanks, > > Jie Yu > >
