----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17440/ -----------------------------------------------------------
(Updated Feb. 7, 2014, 1:50 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Changes ------- - Moved Group change to another review: https://reviews.apache.org/r/17858 - Added comments that watchers are called from a single thread. - Turned out watcher and other classes don't need to change if the watcher is called from a single thread. Bugs: MESOS-937 https://issues.apache.org/jira/browse/MESOS-937 Repository: mesos-git Description ------- Description in JIRA: "Between the execution of ProcessWatcher::~ProcessWatcher() and its base class destructor Watcher::~Watcher(), the pure virtual method Watcher::process() can be invoked by WatcherProcess::event()." By eliminating WatcherProcess this problem is resolved. Diffs (updated) ----- src/zookeeper/zookeeper.hpp f50aca6e7035c8084c3e76fd56b9d1ef7f9d9902 src/zookeeper/zookeeper.cpp 5720f4c1cd51c4d998b52e7bf7f9f019ae80c5f8 Diff: https://reviews.apache.org/r/17440/diff/ Testing ------- make check locally and on Jenkins. File Attachments ---------------- ZK Client States https://reviews.apache.org/media/uploaded/files/2014/01/28/59be560e-3e4a-407a-acc9-baf07183fe32__ZooKeeper_client_states.jpg Thanks, Jiang Yan Xu
