----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/#review34049 -----------------------------------------------------------
Ship it! src/Makefile.am <https://reviews.apache.org/r/17255/#comment64043> Maybe s/health_tests/observe_tests/ ... although I assume you want to add more tests beyond just the observe endpoint? Since we have a 'health' endpoint there is a little ambiguity here. src/tests/health_tests.cpp <https://reviews.apache.org/r/17255/#comment64041> { on newline please. src/tests/health_tests.cpp <https://reviews.apache.org/r/17255/#comment64042> { on newline please. Also, const& on JsonResponse? src/tests/health_tests.cpp <https://reviews.apache.org/r/17255/#comment64044> These macros look great! - Benjamin Hindman On Jan. 30, 2014, 10:13 p.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17255/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 10:13 p.m.) > > > Review request for mesos, Benjamin Hindman and Jeff Currier. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-880 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-880 > > > Repository: mesos-git > > > Description > ------- > > Add observe endpoint to master. > > This changes adds a new HTTP endpoint of observe to master. > This allows clients to report health via an HTTP POST. > Values are: > MONITOR = Monitor for which health is being reported. > HOSTS = Comma seperated list of hosts. > LEVEL = OK for healthy, anything else for unhealthy. > > This also contains a small fix to alphabetize the existing > endpoints / help strings. > > SEE: https://issues.apache.org/jira/browse/MESOS-880 > > Review: https://reviews.apache.org/r/17255 > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c > src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b > src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be > src/tests/health_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17255/diff/ > > > Testing > ------- > > make check > added unit tests in a new health_test.cpp file > > > Thanks, > > Charlie Carson > >
