----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17858/#review34122 -----------------------------------------------------------
src/zookeeper/group.hpp <https://reviews.apache.org/r/17858/#comment64098> Maybe call it INIT? Not clear what is the difference between DISCONNECTED and CONNECTING. src/zookeeper/group.cpp <https://reviews.apache.org/r/17858/#comment64090> s/;/ << state;/ src/zookeeper/group.cpp <https://reviews.apache.org/r/17858/#comment64100> s/retrying/'retrying'/ src/zookeeper/group.cpp <https://reviews.apache.org/r/17858/#comment64097> Seems odd to set 'state' to 2 different states in the same method? - Vinod Kone On Feb. 7, 2014, 10 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17858/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 10 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > - Reconnecting does not reset the state to CONNECTING now. The steps the > group has taken to set up the group are remembered (thus not redone) across > reconnections. > - Improved comments on state transitions. > - Added the DISCONNECTED state back for the parity between Group and > ZooKeeperStorage. > > > Diffs > ----- > > src/zookeeper/group.hpp e51ebb2cf5f09a633462c101f913ee8272be9a6c > src/zookeeper/group.cpp a61a384510c54c152fcf330003e315b870f43bc8 > > Diff: https://reviews.apache.org/r/17858/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
