----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18276/#review34961 -----------------------------------------------------------
Looks great, I'm mostly concerned with this test being flaky due to the lower bound check on CPU time, see my comment below. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/18276/#comment65356> Use write()? ;) src/tests/isolator_tests.cpp <https://reviews.apache.org/r/18276/#comment65357> _exit(1)? ;) src/tests/isolator_tests.cpp <https://reviews.apache.org/r/18276/#comment65358> Couldn't you just touch the file after the 'kill $MESOS_TEST_PID' command, rather than before the 'sleep 0.5'? Seems like you could remove the brittle sleep call here that way, no? src/tests/isolator_tests.cpp <https://reviews.apache.org/r/18276/#comment65359> Yikes, it sounds like this will be pretty flaky! Can you more heavily limit CPU and avoid the need for a lower bound check? - Ben Mahler On Feb. 19, 2014, 9:04 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18276/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 9:04 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Runs a single core cpu bound process for 1 second but limited to 0.25 cpu and > ensures 0.20 <= system + user cpu time <= 0.30. > > > Diffs > ----- > > src/tests/isolator_tests.cpp 9ec285a0da95d2b610037ad3c82e759b8d3bdbd8 > > Diff: https://reviews.apache.org/r/18276/diff/ > > > Testing > ------- > > make check # Linux > > > Thanks, > > Ian Downes > >
