[ 
https://issues.apache.org/jira/browse/MESOS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907200#comment-13907200
 ] 

Dominic Hamon commented on MESOS-361:
-------------------------------------

There's a couple of ways this could be implemented:

1. the JNI/Python/Go bindings are responsible for sanitizing and the core code 
checks
2. the core code rejects invalid IDs
3. the core code sanitizes invalid IDs (replace all bad characters with '_' for 
example)

2. makes it clear to the caller that they did something wrong, though they may 
not have full control over the ID
3. will work in all cases but may cause surprising results for users looking 
for specific IDs in the webui/logs. Maybe logging the result of the 
sanitization is enough?

> Restrict the character space of user provided identifiers.
> ----------------------------------------------------------
>
>                 Key: MESOS-361
>                 URL: https://issues.apache.org/jira/browse/MESOS-361
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Benjamin Mahler
>              Labels: newbie
>
> We need to restrict the character space of our identifiers.
>   -FrameworkID
>   -ExecutorID
>   -ExecutorInfo.source
>   -TaskID
> Using whitespace in these is messy, but using things like forward slashes 
> will break functionality!
> In particular, file system operations using the ids, as well as statistics 
> usage potentially.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to