> On Feb. 16, 2014, 1:44 a.m., Ben Mahler wrote: > >
switched to Repairer :-) - Charlie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17564/#review34577 ----------------------------------------------------------- On Feb. 18, 2014, 9:45 p.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17564/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 9:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone. > > > Bugs: MESOS-957 > https://issues.apache.org/jira/browse/MESOS-957 > > > Repository: mesos-git > > > Description > ------- > > Introduce a Repairer class to master. > > Add a Repairer class to master. Currently it is just a stub, but it will > soon get wired up to the new observe end-point in master and recieve slave > state updates. From there, it will be responsible for persisting the > state > and ultimately performing repairs on unhealthy slaves. > > The Repairer has virtual methods and destructor so that it can easily be > mocked for testing. > > Updated the existing master constructor to take a Repairer* > and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new > up a Repairer, pass it to master's constructor and delete > the Repairer when it's finished. > > Review: https://reviews.apache.org/r/17564 > > > Diffs > ----- > > src/Makefile.am 768c66a5369a05e5633454200880d13620ecb5e6 > src/local/local.cpp 51123911595a7a2ac48458707ded2835935cbcbc > src/master/main.cpp ab4846eaebc13fe619c335c7763ac0b711df3d47 > src/master/master.hpp 9d1b56c6b02eb21130f165848297ae0695ac2af7 > src/master/master.cpp f4f5e04e3f98428137e986f24a0bc897801be482 > src/master/repairer.hpp PRE-CREATION > src/master/repairer.cpp PRE-CREATION > src/tests/cluster.hpp 5100959f5de1e8e93bfbdeba26c95a33fe59f7e1 > > Diff: https://reviews.apache.org/r/17564/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Charlie Carson > >
