> On Feb. 20, 2014, 7:37 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/include/process/collect.hpp, lines 48-51 > > <https://reviews.apache.org/r/18311/diff/1/?file=498993#file498993line48> > > > > Why do you need this when we have the above?
That is mostly a convenience approach, making the code on the user's side as slick as possible. Having a process based await is super useful, I think. Having an override that does just that with a single given future is pretty convenient, isn't it? > On Feb. 20, 2014, 7:37 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/include/process/collect.hpp, lines 288-302 > > <https://reviews.apache.org/r/18311/diff/1/?file=498993#file498993line288> > > > > kill this? See above. > On Feb. 20, 2014, 7:37 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/include/process/collect.hpp, lines 323-326 > > <https://reviews.apache.org/r/18311/diff/1/?file=498993#file498993line323> > > > > Why is this .then? What happens if await() returns a failed future? Then the returned future will be stated to failed. - TILL ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18311/#review35040 ----------------------------------------------------------- On Feb. 20, 2014, 3:59 p.m., TILL TOENSHOFF wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18311/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 3:59 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas > Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Currently the Process::await implementation on list<Future>, by the nature of > std::list, expects equally typed futures. This new override implements await > for a tuple of futures, hence allows awaiting differently typed futures in a > single call. > > A C++11 and a boost-based implementation have been added. > > This patch also includes tests on that new feature. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/c++11/collect.hpp PRE-CREATION > 3rdparty/libprocess/include/process/collect.hpp 2a73bc9 > 3rdparty/libprocess/src/tests/process_tests.cpp e899aed > > Diff: https://reviews.apache.org/r/18311/diff/ > > > Testing > ------- > > make check (clang c++11, gcc) > > > Thanks, > > TILL TOENSHOFF > >
