> On Feb. 20, 2014, 2:06 p.m., Ben Mahler wrote: > > src/common/http.cpp, line 83 > > <https://reviews.apache.org/r/18144/diff/12/?file=499423#file499423line83> > > > > Can you add 'ports' as well? (Sorry I missed this earlier). > > > > One downside to explicitly grabbing things like 'cpus', 'disk', 'mem', > > 'ports' from 'Resources' is that we'll only be exposing these > > "grandfathered" resources. However, Resources are free-form and operators > > can expose any additional resources, like 'users', 'disk_io', 'databases', > > etc. Currently, the perRoleModel() will capture these but the model() > > function will omit them. Not a big deal, but would be great to either fix > > or have a TODO about this!
Given the webui only currently expects the grandfathered resources to exist, I don't think this is a problem at all. When we make perRoleModel the default (as per the TODO) then this won't be a concern at all. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18144/#review35084 ----------------------------------------------------------- On Feb. 20, 2014, 1:50 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18144/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 1:50 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-692 and MESOS-990 > https://issues.apache.org/jira/browse/MESOS-692 > https://issues.apache.org/jira/browse/MESOS-990 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb > src/common/http.hpp PRE-CREATION > src/common/http.cpp PRE-CREATION > src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076 > src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187 > > Diff: https://reviews.apache.org/r/18144/diff/ > > > Testing > ------- > > make check. > > ran master/slave and checked http://localhost:5050/master/state.json by eye. > > ran local/python test framework and watched webui main, framework, and slave > pages. > > > Thanks, > > Dominic Hamon > >
