----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17476/#review35181 -----------------------------------------------------------
Ship it! LGTM. But I would like BenH to take a look. 3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65607> s/this/these/ ? s/register/registering/ 3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65613> Awesome graph. Maybe N1, N2 and N3 and T1 T2 and T3 would make it even better to read? Also consider s/T/F/ so that it is easy to understand that N => "next/notifier" and F ==> "future" in the code. 3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65616> s/arrow// ? 3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65617> s/arrow// ? s/'N'/ previous 'N'/ 3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65636> Why is this templated? 3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65628> We typically prefix "_" for methods that are continuations. Though in this particular case "_add" is not a continuation of "add" 3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65629> "__add" here is a bit confusing because this is not a continuation of "_add". 3rdparty/libprocess/src/tests/sequence_tests.cpp <https://reviews.apache.org/r/17476/#comment65641> Add a comment on what this test is testing? 3rdparty/libprocess/src/tests/sequence_tests.cpp <https://reviews.apache.org/r/17476/#comment65642> Ditto. Comment. 3rdparty/libprocess/src/tests/sequence_tests.cpp <https://reviews.apache.org/r/17476/#comment65643> Ditto. Comment. - Vinod Kone On Feb. 21, 2014, 5:03 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17476/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 5:03 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > One think I haven't done yet is to make it accepts '_Defer' types. (Just > curious why Future.onAny can accept defer without doing something special). > > Also, we can get rid of the SequencerProcess if we use a mutex to protect > 'last'. Not sure which one is better. > > The discard semantics here is a bit tricky. Basically, I wanna support > discarding a single callback without affecting other callbacks. Also, when > the Sequencer object is deleted, I wanna discard all the pending callbacks. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am a7d199f > 3rdparty/libprocess/include/process/sequence.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/sequence_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17476/diff/ > > > Testing > ------- > > make check > > repeated 1000 times > > > Thanks, > > Jie Yu > >
