----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18249/#review35349 -----------------------------------------------------------
Ship it! Some trivial comments below, I'll do these for you when I pull down the patch! src/master/http.cpp <https://reviews.apache.org/r/18249/#comment65813> Please end with a period. src/master/http.cpp <https://reviews.apache.org/r/18249/#comment65814> Please end with a period. src/slave/http.cpp <https://reviews.apache.org/r/18249/#comment65815> Please end with a period. src/slave/http.cpp <https://reviews.apache.org/r/18249/#comment65816> Please end with a period. - Ben Mahler On Feb. 22, 2014, 1:22 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18249/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2014, 1:22 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1015 > https://issues.apache.org/jira/browse/MESOS-1015 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp > 96b6ad569ea3758e4d078c6b2d60da4ea4fe8693 > src/master/http.cpp 6654cac1b5e33f548a555ee516b3823dfb2f854e > src/master/master.hpp 768dc3d165510d9e65e4b44075256b2805fde18c > src/master/master.cpp de40884f873656cf91566ef49736cb8dda1300d8 > src/slave/http.cpp 7ed9abe704b852c0237886ad59ff94b31ac4fb24 > src/slave/slave.hpp d82d4e9547fc8c44f2210e1fafec766c381ab35c > src/slave/slave.cpp 7ad823244eb8e9a2bc3899bdf728a5faed4eafbd > src/slave/status_update_manager.hpp > d29e269b00de0fc63d6281976f5efe1218ba9ba9 > src/slave/status_update_manager.cpp > a88bb183b5122ff5adc59a0e6e697f7f9b2a3945 > > Diff: https://reviews.apache.org/r/18249/diff/ > > > Testing > ------- > > no functional change expected. > > built. ran make check. > > > Thanks, > > Dominic Hamon > >
