----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18600/#review35799 -----------------------------------------------------------
src/log/recover.hpp <https://reviews.apache.org/r/18600/#comment66557> It looks like you always pass a value in for autoInitialization - is there a reason for it to have a default? src/log/recover.cpp <https://reviews.apache.org/r/18600/#comment66559> switch might be cleaner now there's more cases. - Dominic Hamon On Feb. 27, 2014, 4:59 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18600/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 4:59 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-984 > https://issues.apache.org/jira/browse/MESOS-984 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/log.hpp 628a4b8 > src/log/log.cpp 7f855f2 > src/log/recover.hpp 634bc06 > src/log/recover.cpp 3403b47 > src/tests/log_tests.cpp 1e59b24 > > Diff: https://reviews.apache.org/r/18600/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
