> On March 5, 2014, 12:54 a.m., Ben Mahler wrote: > > src/log/replica.cpp, lines 268-269 > > <https://reviews.apache.org/r/18368/diff/3/?file=507720#file507720line268> > > > > If this is really an error, why are we returning an empty interval set? > > Jie Yu wrote: > Well, this matches the previous semantics. I don't wanna introduce a new > semantics here. Added a TODO to clean this up later.
Well, this matches the previous semantics. I don't wanna introduce a new semantics here. > On March 5, 2014, 12:54 a.m., Ben Mahler wrote: > > src/log/replica.cpp, lines 268-269 > > <https://reviews.apache.org/r/18368/diff/3/?file=507720#file507720line268> > > > > If this is really an error, why are we returning an empty interval set? > > Jie Yu wrote: > Well, this matches the previous semantics. I don't wanna introduce a new > semantics here. Well, this matches the previous semantics. I don't wanna introduce a new semantics here. Added a TODO to clean this up later. > On March 5, 2014, 12:54 a.m., Ben Mahler wrote: > > src/log/catchup.cpp, line 150 > > <https://reviews.apache.org/r/18368/diff/3/?file=507716#file507716line150> > > > > Why did you change this name? Was the signature not enough? Reverted. I needed that to disambiguate overloaded functions for lambda. Now, I explicitly disambiguate it. > On March 5, 2014, 12:54 a.m., Ben Mahler wrote: > > src/log/catchup.cpp, line 227 > > <https://reviews.apache.org/r/18368/diff/3/?file=507716#file507716line227> > > > > current == positions.upper() ? > > > > Seems like we should really make sure it's not greater! Maybe a CHECK? Added a CHECK. > On March 5, 2014, 12:54 a.m., Ben Mahler wrote: > > src/log/catchup.cpp, lines 330-331 > > <https://reviews.apache.org/r/18368/diff/3/?file=507716#file507716line330> > > > > Do we need a Promise? > > > > Looks like we could just use a 'Future<Nothing> f = Nothing()' unless > > you want to delay starting the chain until all the callbacks were > > registered? Fixed. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18368/#review36198 ----------------------------------------------------------- On March 1, 2014, 7:34 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18368/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 7:34 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/catchup.hpp 45dc016 > src/log/catchup.cpp dae4619 > src/log/coordinator.cpp 6bfff1e > src/log/recover.cpp 3403b47 > src/log/replica.hpp 08ddcb1 > src/log/replica.cpp 1f1a945 > src/log/storage.hpp c0eba1b > src/tests/log_tests.cpp 0e2485f > > Diff: https://reviews.apache.org/r/18368/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
