----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18823/#review36293 -----------------------------------------------------------
src/tests/group_tests.cpp <https://reviews.apache.org/r/18823/#comment67246> Does this compile? Why explicit here? - Jie Yu On March 5, 2014, 11:54 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18823/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 11:54 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1055 > https://issues.apache.org/jira/browse/MESOS-1055 > > > Repository: mesos-git > > > Description > ------- > > Put "explicit" in front of all single-argument constructors in C++ Mesos > source code. (Omitted lib process, filed a separate issue for it.) > > > Diffs > ----- > > src/examples/long_lived_framework.cpp dc123cd > src/log/log.cpp 7f855f2 > src/log/replica.hpp 08ddcb1 > src/log/replica.cpp 1f1a945 > src/master/contender.cpp 42d9c07 > src/master/detector.cpp 3a8aaed > src/master/registrar.cpp 37337c0 > src/tests/cgroups_tests.cpp 4a092cc > src/tests/group_tests.cpp b265bcb > src/zookeeper/detector.cpp e186e51 > support/cpplint.py a8c9f67 > > Diff: https://reviews.apache.org/r/18823/diff/ > > > Testing > ------- > > Compiled on Mac OS 10.9 with Clang 3.3 and on Ubuntu 13.10 with gcc 4.7.1. > Ran make check on both. > > Also ran: python cpplint.py --filter=-,+runtime/explicit `find mesos -name > '*.cpp'; find mesos -name '*.hpp'` > And due to the patch, no more warnings about explicit constructors inside > Mesos source code. > > Note that cpplint.py is now patched to allow '*.hpp' files, which it did not. > > > Thanks, > > Bernd Mathiske > >
