> On March 9, 2014, 11:18 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [18947] > > > > Failed command: make -j3 check GTEST_FILTER='' >/dev/null > > > > Error: > > ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared > > 'extern' [enabled by default] > > ev.c: In function 'evpipe_write': > > ev.c:2160:17: warning: ignoring return value of 'write', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c:2172:17: warning: ignoring return value of 'write', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c: In function 'pipecb': > > ev.c:2193:16: warning: ignoring return value of 'read', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c:2207:16: warning: ignoring return value of 'read', declared with > > attribute warn_unused_result [-Wunused-result] > > In file included from /usr/include/c++/4.6/ext/hash_set:61:0, > > from src/glog/stl_logging.h:54, > > from src/stl_logging_unittest.cc:34: > > /usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning > > This file includes at least one deprecated or antiquated header which may > > be removed without further notice at a future date. Please use a > > non-deprecated interface with equivalent functionality instead. For a > > listing of replacement headers and interfaces, consult the file > > backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp] > > In file included from src/utilities.h:73:0, > > from src/googletest.h:38, > > from src/stl_logging_unittest.cc:48: > > src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by > > default] > > /usr/include/features.h:166:0: note: this is the location of the previous > > definition > > warning: no files found matching 'Makefile' under directory 'docs' > > warning: no files found matching 'indexsidebar.html' under directory 'docs' > > zip_safe flag not set; analyzing archive contents... > > WARNING: '.' not a valid package name; please use only.-separated package > > names in setup.py > > package init file 'src/__init__.py' not found (or not a regular file) > > cc1plus: warning: command line option '-Wstrict-prototypes' is valid for > > Ada/C/ObjC but not for C++ [enabled by default] > > cc1plus: warning: command line option '-Wstrict-prototypes' is valid for > > Ada/C/ObjC but not for C++ [enabled by default] > > cc1plus: warning: command line option '-Wstrict-prototypes' is valid for > > Ada/C/ObjC but not for C++ [enabled by default] > > cc1plus: warning: command line option '-Wstrict-prototypes' is valid for > > Ada/C/ObjC but not for C++ [enabled by default] > > cc1plus: warning: command line option '-Wstrict-prototypes' is valid for > > Ada/C/ObjC but not for C++ [enabled by default] > > g++: error: : No such file or directory > > error: command 'g++' failed with exit status 1 > > make[2]: *** [python/dist/mesos-0.19.0-py2.7-linux-x86_64.egg] Error 1 > > make[2]: *** Waiting for unfinished jobs.... > > make[1]: *** [check] Error 2 > > make: *** [check-recursive] Error 1 > >
Interesting failure. Seems to be caused when LDFLAGS are getting stuffed into EXTRA_LINK_ARGS - not on OSX but only on linux systems. Workaround upcoming... - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18947/#review36618 ----------------------------------------------------------- On March 9, 2014, 10:53 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18947/ > ----------------------------------------------------------- > > (Updated March 9, 2014, 10:53 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas > Nielsen, and Vinod Kone. > > > Bugs: MESOS-550 > https://issues.apache.org/jira/browse/MESOS-550 > > > Repository: mesos-git > > > Description > ------- > > The python-egg build-process now checks if libzookeeper_mt.a has been > produced. Added LDFLAGS propagation into setup.py. > > > Diffs > ----- > > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/18947/diff/ > > > Testing > ------- > > ../configure CPPFLAGS=-I/usr/local/include/zookeeper LDFLAGS=-L/usr/local/lib > --without-included-zookeeper > make check > > and > > ../configure > make check > > > Thanks, > > Till Toenshoff > >
