> On March 4, 2014, 2:11 a.m., Ben Mahler wrote: > > src/tests/log_tests.cpp, lines 1462-1464 > > <https://reviews.apache.org/r/17345/diff/2/?file=497565#file497565line1462> > > > > Do you need to store 'start'? > > > > AWAIT_READY(writer.start());
Yes, I should check that start returned some position! Fixed. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17345/#review36061 ----------------------------------------------------------- On Feb. 19, 2014, 8:03 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17345/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 8:03 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/java/jni/org_apache_mesos_Log.cpp > 36c636d155c1581eeb7734cdbc5b6fac4ca42440 > src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5 > src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2 > src/log/tool/benchmark.cpp 7d5a032ec4f1652ce80f2486989c01cb6f29a5d4 > src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24 > > Diff: https://reviews.apache.org/r/17345/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
