----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18946/ -----------------------------------------------------------
(Updated March 11, 2014, 12:32 p.m.) Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, Timothy St. Clair, and Vinod Kone. Changes ------- Addressed comments: - JNI library now is versioned and marked as shared while building - fixed spaces Added omitted patches to: - containerizer - tests-environment Bugs: MESOS-855 https://issues.apache.org/jira/browse/MESOS-855 Repository: mesos-git Description ------- Introduced a new environment variable (MESOS_NATIVE_JAVA_LIBRARY). That variable points towards libmesos_java. libmesos_java contains the JNI- specific code (formally part of libmesos) and dynamically links against libmesos. A typical java-based framework relies on mesos.jar to do the loading but may use some extra logic in its startup to make sure MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic would need to be adapted to use the new environment variable instead of the old one. Diffs (updated) ----- bin/mesos-slave-flags.sh.in dc73aef src/Makefile.am 384b312 src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2 src/slave/containerizer/containerizer.cpp d0a1023 src/tests/environment.cpp 5c92fcd Diff: https://reviews.apache.org/r/18946/diff/ Testing ------- make check and functional testing with external, java based frameworks Thanks, Till Toenshoff