----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18910/#review36882 -----------------------------------------------------------
Looks good. I wonder if a more explicit dependency documentation would help. Wouldn't it also be great to warn users that mesos-ec2 services wont be usable when boto was not detected on their system? docs/getting-started.md <https://reviews.apache.org/r/18910/#comment68076> Would you mind moving python-boto into another line and adding a comment to make the need for python-boto it a bit more explicit? pip would be commonly used for installing python modules and that is AFAIK the only non tarball distribution for our OSX users. - Till Toenshoff On March 7, 2014, 10:58 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18910/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 10:58 p.m.) > > > Review request for mesos, Benjamin Hindman and Till Toenshoff. > > > Bugs: MESOS-1072 > https://issues.apache.org/jira/browse/MESOS-1072 > > > Repository: mesos-git > > > Description > ------- > > Python boto exists on nearly all platforms that I can think of. It makes > sense to add the check to configure and remove from the repo. > > > Diffs > ----- > > 3rdparty/Makefile.am 8e1d915 > 3rdparty/versions.am 102d6f4 > LICENSE b45416f > configure.ac 91ddf57 > docs/getting-started.md 3379f9d > ec2/mesos-ec2 3bc5d63 > m4/ac_python_module.m4 PRE-CREATION > mesos.pc.in PRE-CREATION > > Diff: https://reviews.apache.org/r/18910/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Timothy St. Clair > >
