----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19208/#review37220 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/19208/#comment68642> This should be abstracted away in stout. Also, consider adding a method on Socket call that gives the IP of the remote end point. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/19208/#comment68641> We avoid doing LOG(INFO) in our 3rd party libraries. Convert this to VLOG instead. More importantly, at Twitter we have observed that these LOGs are actually useful during debugging and hence we wanted these to be always present (i.e., LOG(INFO) instead of VLOG). That's likely the reason these are in http.cpp files. - Vinod Kone On March 14, 2014, 4:31 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19208/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 4:31 p.m.) > > > Review request for mesos, Benjamin Hindman and Ian Downes. > > > Bugs: MESOS-1096 > https://issues.apache.org/jira/browse/MESOS-1096 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 6c6acc03ad78779e8f25b1a4584069fd377f647b > src/master/http.cpp a019f15615d028f3d3628b2611709fc8a3a81bf8 > src/slave/http.cpp 594032da1b2edd47961cd8201acd093b22fa30ae > > Diff: https://reviews.apache.org/r/19208/diff/ > > > Testing > ------- > > make check > > ran locally and connected to :5050 endpoint and watched log > > > Thanks, > > Dominic Hamon > >
