----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19242/#review37587 -----------------------------------------------------------
configure.ac <https://reviews.apache.org/r/19242/#comment69181> Why not move all of this within the else block below? configure.ac <https://reviews.apache.org/r/19242/#comment69182> . configure.ac <https://reviews.apache.org/r/19242/#comment69183> What if it's 4.8.1? That's why we used the 'case' approach in the past. configure.ac <https://reviews.apache.org/r/19242/#comment69185> Please re-wrap this. configure.ac <https://reviews.apache.org/r/19242/#comment69186> Can you format this error like we do for others in this file please? For example: AC_MSG_ERROR([ ------------------------------------------------------------------- Mesos's use of C++11 is currently unsupported for your compiler (g++ $GCC_VERSION) -- please pass --without_cxx11 to configure. ------------------------------------------------------------------- ]) - Benjamin Hindman On March 17, 2014, 7:15 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19242/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 7:15 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1095 > https://issues.apache.org/jira/browse/MESOS-1095 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a > > Diff: https://reviews.apache.org/r/19242/diff/ > > > Testing > ------- > > make check under g++-4.7 and g++-4.8, with and without c++11 > > > Thanks, > > Dominic Hamon > >
