----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19389/#review37743 -----------------------------------------------------------
src/sasl/authenticatee.hpp <https://reviews.apache.org/r/19389/#comment69388> Have we avoided any copying by doing this? From char* to string we are still copying, right? How does it compare to: promise.fail("Failed to initialize SASL: " + std::string(sasl_errstring(result, NULL, NULL))); - Jiang Yan Xu On March 18, 2014, 10:16 p.m., Archana kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19389/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 10:16 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/sasl/authenticatee.hpp 42a4eba > > Diff: https://reviews.apache.org/r/19389/diff/ > > > Testing > ------- > > > Thanks, > > Archana kumari > >
