----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19501/#review38016 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp <https://reviews.apache.org/r/19501/#comment69931> I wonder if 'Basic' and 'More' are too generic for unit test cases here, what about creating more targeted tests of functionality? Might be beneficial to look at related tests, like: linkedhashmap_tests.cpp - Ben Mahler On March 20, 2014, 11:08 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19501/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 11:08 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1123 > https://issues.apache.org/jira/browse/MESOS-1123 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 84931554341376229386a3a853470ee7c4f89c5f > 3rdparty/libprocess/3rdparty/stout/Makefile.am > df149ddc8669b0c541361922631f4f3958bd096d > 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp > 67b88bc5959e2d8c2cee5c0a218229c293afcf60 > 3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19501/diff/ > > > Testing > ------- > > make check -j GTEST_FILTER=*Cache* > > > Thanks, > > Jiang Yan Xu > >
