> On March 20, 2014, 3:58 p.m., Ben Mahler wrote: > > I think I'm missing some context on this review and it would take me a bit > > of time to page it in from the discussion on JIRA. Would you like Vinod or > > Ian to be the main reviewer for this?
Hey Ben, That would be great! To avoid requiring or injecting a Mesos environment into containers to run commands (remember our container matrix? think it should be in JIRA), we can use the command executor to run containers underneath the cover. For that, it would be useful to be able to run ./mesos-executor <container executuable> The Docker external containerizer: https://github.com/mesosphere/deimos depends on it at the moment. @Jason can also add some context :) - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18601/#review38004 ----------------------------------------------------------- On March 13, 2014, 1:10 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18601/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 1:10 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > As discussed during the architecture discussion for pluggable > containerization(see https://issues.apache.org/jira/browse/MESOS-816), we > proposed that the command executor could be exposed for (the slightly unusual > use-case) of launching containers. > This is important in particular, when launching containers which can be > considered _being_ the command, for example a docker image which runs the > necessary services (mysql, memcache and so on) through it's usual init system. > We therefore need a way start the command executor with this use-case in > mind. This patch adds support for passing and overwriting the command to > launch from the command line. > > > Diffs > ----- > > src/launcher/executor.cpp e30d77a > > Diff: https://reviews.apache.org/r/18601/diff/ > > > Testing > ------- > > Usual behavior of mesos-executor doesn't change. This is used and has been > tested with https://github.com/mesosphere/deimos. > > > Thanks, > > Niklas Nielsen > >
