> On March 19, 2014, 11:49 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/metrics/metric.cpp, line 46 > > <https://reviews.apache.org/r/18718/diff/6/?file=525869#file525869line46> > > > > It looks like there could be a nasty race here where the Metric gets > > deleted but something that still has 'this' (from the 'add' call) might try > > and use the now cleaned up memory. > > Ben Mahler wrote: > Should this be dropped, or is it still an issue?
Once again I replied in the diff instead of the review. One of these days I'll remember not to do that: The caller owns the metric. If they decide to destroy the metric and then use it they're doing C++ wrong. There might be a race between a metric going out of scope, remove being dispatched, and someone hitting the end point before the process runs remove. I suppose the best option is to wait on remove's returned Future? I don't know enough about the guarantees of order of calls in libprocess to know if this case is a concern. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/#review37749 ----------------------------------------------------------- On March 20, 2014, 2:44 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18718/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 2:44 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/metrics/counter.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/gauge.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metric.cpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metrics.hpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metrics.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 6c6acc03ad78779e8f25b1a4584069fd377f647b > 3rdparty/libprocess/src/tests/metrics_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18718/diff/ > > > Testing > ------- > > Added unit tests. make check. > > > Thanks, > > Dominic Hamon > >
