> On March 18, 2014, 7 p.m., Dominic Hamon wrote: > > src/authorizer/authorizer.hpp, line 89 > > <https://reviews.apache.org/r/18730/diff/4/?file=520218#file520218line89> > > > > I understand that it's implicitly inlined, and that's the issue I'm > > raising. It's quite a bit of code to be inlined and lots of implementation > > details that people reading the header don't need to know about.
Considering this is how the rest of code base is, I will leave it as is for consistency. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18730/#review37602 ----------------------------------------------------------- On March 21, 2014, 11:44 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18730/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 11:44 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Bugs: MESOS-911 > https://issues.apache.org/jira/browse/MESOS-911 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7fcd23d467b1274c46c405b836510afbd49 > src/Makefile.am 0775a0df293e945d41c7ba90fd1bbb503ae22f9e > src/authorizer/authorizer.hpp PRE-CREATION > src/tests/authorization_tests.cpp PRE-CREATION > src/tests/master_contender_detector_tests.cpp > 8da7420e18c7a960b566fae13a5975857eb777ee > > Diff: https://reviews.apache.org/r/18730/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
