-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/#review38291
-----------------------------------------------------------
Bad patch!
Reviews applied: [18718, 19499]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
In file included from src/tests/metrics_tests.cpp:5:0:
./include/process/metrics/counter.hpp: In member function 'virtual double
process::metrics::Counter::get() const':
./include/process/metrics/counter.hpp:21:48: error: invalid conversion from
'const volatile void*' to 'volatile void*' [-fpermissive]
make[5]: *** [tests-metrics_tests.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [check-am] Error 2
make[3]: *** [check-recursive] Error 1
make[2]: *** [check-recursive] Error 1
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 20, 2014, 10:52 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19499/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 10:52 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1133
> https://issues.apache.org/jira/browse/MESOS-1133
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/slave/http.cpp 594032da1b2edd47961cd8201acd093b22fa30ae
> src/slave/slave.hpp 01b80dfc1dd55edd6d2f722ff1d4f1bf4d96f28e
> src/slave/slave.cpp d8d3e0fa54972201d72b2650ec0ba922a4912d54
>
> Diff: https://reviews.apache.org/r/19499/diff/
>
>
> Testing
> -------
>
> make check. ran locally and compared stats.json endpoint to /metrics/
> endpoint.
>
>
> Thanks,
>
> Dominic Hamon
>
>
