-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19545/#review38333
-----------------------------------------------------------
Bad patch!
Reviews applied: [18718, 19545]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
In file included from src/process.cpp:63:0:
./include/process/system.hpp: In constructor 'process::System::System()':
./include/process/system.hpp:29:62: error: no matching function for call to
'process::metrics::Gauge::Gauge(std::string, const char [14], double (&)())'
./include/process/system.hpp:29:62: note: candidates are:
./include/process/metrics/gauge.hpp:18:3: note:
process::metrics::Gauge::Gauge(const string&, const string&, const
process::Deferred<process::Future<double>()>&)
./include/process/metrics/gauge.hpp:18:3: note: no known conversion for
argument 3 from 'double()' to 'const
process::Deferred<process::Future<double>()>&'
./include/process/metrics/gauge.hpp:15:7: note:
process::metrics::Gauge::Gauge(const process::metrics::Gauge&)
./include/process/metrics/gauge.hpp:15:7: note: candidate expects 1 argument,
3 provided
./include/process/system.hpp:29:62: error: no matching function for call to
'process::metrics::Gauge::Gauge(std::string, const char [14], double (&)())'
./include/process/system.hpp:29:62: note: candidates are:
./include/process/metrics/gauge.hpp:18:3: note:
process::metrics::Gauge::Gauge(const string&, const string&, const
process::Deferred<process::Future<double>()>&)
./include/process/metrics/gauge.hpp:18:3: note: no known conversion for
argument 3 from 'double()' to 'const
process::Deferred<process::Future<double>()>&'
./include/process/metrics/gauge.hpp:15:7: note:
process::metrics::Gauge::Gauge(const process::metrics::Gauge&)
./include/process/metrics/gauge.hpp:15:7: note: candidate expects 1 argument,
3 provided
./include/process/system.hpp:29:62: error: no matching function for call to
'process::metrics::Gauge::Gauge(std::string, const char [15], double (&)())'
./include/process/system.hpp:29:62: note: candidates are:
./include/process/metrics/gauge.hpp:18:3: note:
process::metrics::Gauge::Gauge(const string&, const string&, const
process::Deferred<process::Future<double>()>&)
./include/process/metrics/gauge.hpp:18:3: note: no known conversion for
argument 3 from 'double()' to 'const
process::Deferred<process::Future<double>()>&'
./include/process/metrics/gauge.hpp:15:7: note:
process::metrics::Gauge::Gauge(const process::metrics::Gauge&)
./include/process/metrics/gauge.hpp:15:7: note: candidate expects 1 argument,
3 provided
./include/process/system.hpp:29:62: error: no matching function for call to
'process::metrics::Gauge::Gauge(std::string, const char [11], double (&)())'
./include/process/system.hpp:29:62: note: candidates are:
./include/process/metrics/gauge.hpp:18:3: note:
process::metrics::Gauge::Gauge(const string&, const string&, const
process::Deferred<process::Future<double>()>&)
./include/process/metrics/gauge.hpp:18:3: note: no known conversion for
argument 3 from 'double()' to 'const
process::Deferred<process::Future<double>()>&'
./include/process/metrics/gauge.hpp:15:7: note:
process::metrics::Gauge::Gauge(const process::metrics::Gauge&)
./include/process/metrics/gauge.hpp:15:7: note: candidate expects 1 argument,
3 provided
./include/process/system.hpp:29:62: error: no matching function for call to
'process::metrics::Gauge::Gauge(std::string, const char [16], double (&)())'
./include/process/system.hpp:29:62: note: candidates are:
./include/process/metrics/gauge.hpp:18:3: note:
process::metrics::Gauge::Gauge(const string&, const string&, const
process::Deferred<process::Future<double>()>&)
./include/process/metrics/gauge.hpp:18:3: note: no known conversion for
argument 3 from 'double()' to 'const
process::Deferred<process::Future<double>()>&'
./include/process/metrics/gauge.hpp:15:7: note:
process::metrics::Gauge::Gauge(const process::metrics::Gauge&)
./include/process/metrics/gauge.hpp:15:7: note: candidate expects 1 argument,
3 provided
./include/process/system.hpp:29:62: error: no matching function for call to
'process::metrics::Gauge::Gauge(std::string, const char [15], double (&)())'
./include/process/system.hpp:29:62: note: candidates are:
./include/process/metrics/gauge.hpp:18:3: note:
process::metrics::Gauge::Gauge(const string&, const string&, const
process::Deferred<process::Future<double>()>&)
./include/process/metrics/gauge.hpp:18:3: note: no known conversion for
argument 3 from 'double()' to 'const
process::Deferred<process::Future<double>()>&'
./include/process/metrics/gauge.hpp:15:7: note:
process::metrics::Gauge::Gauge(const process::metrics::Gauge&)
./include/process/metrics/gauge.hpp:15:7: note: candidate expects 1 argument,
3 provided
make[4]: *** [libprocess_la-process.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [check-recursive] Error 1
make[2]: *** [check-recursive] Error 1
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 24, 2014, 6:09 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19545/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 6:09 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION
> 3rdparty/libprocess/include/process/system.hpp
> fbd1eaa1de44eb419cef4c78efd6d138eabc7b44
>
> Diff: https://reviews.apache.org/r/19545/diff/
>
>
> Testing
> -------
>
> make check and manually checked /system/stats.json against /metrics
>
>
> Thanks,
>
> Dominic Hamon
>
>
