----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19361/#review38341 -----------------------------------------------------------
A few questions about the tests: 1. Why are you forking and using clone instead of pthread_create? Comments please :) 2. If you're going to fork, are you able to use the <stout/fork.hpp> abstractions to clean it up? - Ben Mahler On March 21, 2014, 8:53 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19361/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 8:53 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Use directory entries in /proc/<pid>/task/ to get threads for <pid>. > > Two tests added which create children with 0 and 2 additional threads. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp > 201e4b88e352baf4ce0549c6359c034a3e1d960d > 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp > bc7e24821ef0bf887f0879033b0bb8dab70dcc2e > > Diff: https://reviews.apache.org/r/19361/diff/ > > > Testing > ------- > > make check # Linux > > > Thanks, > > Ian Downes > >
