> On March 25, 2014, 12:42 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 172 > > <https://reviews.apache.org/r/19556/diff/4/?file=534342#file534342line172> > > > > Do you expect this to be used outside tests?
Yes, it will be used when we create filters (match a given MAC address). - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19556/#review38398 ----------------------------------------------------------- On March 24, 2014, 10:16 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19556/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 10:16 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 8493155 > 3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6 > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19556/diff/ > > > Testing > ------- > > make check on both OSX and Linux > > ALso, manually verified with the output from ifconfig/ip link show > > > Thanks, > > Jie Yu > >
