----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19248/#review38696 -----------------------------------------------------------
Ship it! src/local/local.cpp <https://reviews.apache.org/r/19248/#comment70993> Do we need this now that the flag is optional? - Vinod Kone On March 27, 2014, 1:35 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19248/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 1:35 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-327 > https://issues.apache.org/jira/browse/MESOS-327 > > > Repository: mesos-git > > > Description > ------- > > This functionality is intended to support monitoring of the slave's > resources, specifically memory and cpu. This is done by moving the slave into > a cpuacct and memory cgroup under > $cgroups_hierarchy/{cpuacct,memory}/$cgroups_root/slave. > > cgroup statistics will be of the slave itself plus any child process that > isn't moved to another cgroup, e.g., mesos-fetcher will be accounted but > executors will not. > > > Diffs > ----- > > src/local/local.cpp 2cfdf49c9eb92302502eb50c623f9606977b88b6 > src/slave/flags.hpp c9a627bc405a48da5d5ef9a90355970151fd6149 > src/slave/slave.cpp 0d712ee1f5351965d6643a8a984a347c61075876 > src/tests/allocator_tests.cpp 31cc8363fd647f3358d684b8a49b8bf657d94dd2 > src/tests/cgroups_tests.cpp 4a092cc5d60f1e9603c8524e686c71728da85f73 > src/tests/cluster.hpp 40d9f8c18307aead2374396710f9a82466e3a716 > src/tests/master_tests.cpp 39c8c23a8459d1bc7174e073221d7bb72f995bc8 > src/tests/mesos.cpp 96adeac27b0de691e0f30530f4bb4da4d3d0f842 > src/tests/resource_offers_tests.cpp > cf910e5928bd7509139ec1b98459eb68a88065f1 > src/tests/slave_recovery_tests.cpp 40a9599787918b78790462e81729ec7ac2395509 > > Diff: https://reviews.apache.org/r/19248/diff/ > > > Testing > ------- > > make check # Linux, as root and non-root > make check # OSX, as non-root only, see MESOS-812 > > > Thanks, > > Ian Downes > >
