-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18381/#review38803
-----------------------------------------------------------
Bad patch!
Reviews applied: [18381]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
zip_safe flag not set; analyzing archive contents...
master/master.cpp: In member function 'void
mesos::internal::master::Master::authenticate(const process::UPID&, const
process::UPID&, const Option<mesos::internal::AuthenticateMessage_Type>&)':
master/master.cpp:2633:25: error: 'disconnect' was not declared in this scope
make[2]: *** [master/libmesos_no_3rdparty_la-master.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 27, 2014, 7:23 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18381/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 7:23 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-804
> https://issues.apache.org/jira/browse/MESOS-804
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added authentication support for slaves.
> Fixes MESOS-804.
>
> Open Questions:
> - Should AuthenticateMessage be replaced with AuthenticateFrameworkMessage,
> or specify an Authenticatee type as coded here?
> - When multiple entries for the same principal exist in the credentials file,
> only the last entry is used. Acceptable behavior, but shouldn't this be
> documented?
>
>
> Diffs
> -----
>
> src/master/flags.hpp 024f86d
> src/master/master.hpp b6b9983
> src/master/master.cpp 5d0ddb0
> src/messages/messages.proto bba17a9
> src/sasl/authenticatee.hpp 42a4eba
> src/sasl/common.hpp PRE-CREATION
> src/sched/sched.cpp 3684cfe
> src/slave/flags.hpp d5c54c0
> src/slave/slave.hpp 15e23ce
> src/slave/slave.cpp 6d901dc
> src/tests/authentication_tests.cpp 127c5e6
> src/tests/cluster.hpp 11684d9
> src/tests/mesos.cpp ae3aeee
> src/tests/sasl_tests.cpp 945426d
> src/tests/slave_recovery_tests.cpp 72b6d42
>
> Diff: https://reviews.apache.org/r/18381/diff/
>
>
> Testing
> -------
>
> make check; manually tested flatfile slave authentication success/failure.
> Added new slave authentication unit tests in authentication_tests.cpp.
>
>
> Thanks,
>
> Adam B
>
>
