> On March 27, 2014, 12:36 p.m., Vinod Kone wrote: > > support/mesos-style.py, lines 76-77 > > <https://reviews.apache.org/r/19743/diff/1/?file=538609#file538609line76> > > > > just curious. what are these rules testing?
build/class checks that a full class declaration can be found. It's partly a parsing check, but it's also if you forget the last '}' or have some extra/missing braces within a class declaration. build/deprecated checks for certain deprecated constructs like >? and <? (max and min operators). - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19743/#review38794 ----------------------------------------------------------- On March 27, 2014, 2:35 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19743/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 2:35 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > see summary. Also added two trivial rules to check. > > > Diffs > ----- > > support/mesos-style.py b27e3fb9dbd72d6f0b8d6e6c6af6b7f8ec7a2351 > > Diff: https://reviews.apache.org/r/19743/diff/ > > > Testing > ------- > > ? support/mesos-style.py > Checking 403 files using filter > --filter=-,+whitespace/tab,+build/class,+build/deprecated > Total errors found: 0 > > > Thanks, > > Dominic Hamon > >
