-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16625/
-----------------------------------------------------------

(Updated April 2, 2014, 5:53 p.m.)


Review request for mesos and Ian Downes.


Changes
-------

Assigning to Ian to shepherd -- Vinod.


Bugs: MESOS-891
    https://issues.apache.org/jira/browse/MESOS-891


Repository: mesos-git


Description
-------

- Not all subsystems are immediately detached after cgroups::cleanup() exits.
- Cgroups-related test cases now wait for detached() after calling 
cgroups::cleanup() in *TearDown().
- cgroups::detached() is a separate function instead of being embedded in 
cgroups::cleanup() because cgroups::cleanup() does not always detach all 
subsystems.
    - "a single subsystem can be attached to two hierarchies if both of those 
hierarchies have only that subsystem attached.": 
https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Resource_Management_Guide/sec-Relationships_Between_Subsystems_Hierarchies_Control_Groups_and_Tasks.html


Diffs
-----

  src/linux/cgroups.hpp cefa476cffb7de50925387a83526ef2f84d7d69c 
  src/linux/cgroups.cpp 19ab1f348191ab0315271477b206aa8c6456fd5a 
  src/tests/cgroups_tests.cpp 0e9316d6561a1339bd2a3fb3482277658beba12b 
  src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364 

Diff: https://reviews.apache.org/r/16625/diff/


Testing
-------

make check
./bin/mesos-tests.sh -j --gtest_filter=SlaveRecoveryTest/1.SchedulerFailover 
--gtest_repeat=1000


Thanks,

Jiang Yan Xu

Reply via email to