----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19948/#review39330 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/19948/#comment71677> why not hashmap? 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/19948/#comment71680> Can you also take this opportunity to cleanup FlagsBase::extract() to use os::environment() instead of os::environ()? That's the only place where it is used afaict. 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/19948/#comment71679> this could be EXPECT_TRUE(environment.contains(key)) if os::environment returns a hashmap. - Vinod Kone On April 2, 2014, 5:52 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19948/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 5:52 p.m.) > > > Review request for mesos, Dominic Hamon and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 901e5550c82c12934a6b9c3154f030c677e41a38 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 1babc1892dff0026c5d12178616a7a8457858eaa > > Diff: https://reviews.apache.org/r/19948/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
